launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> 
> === modified file 'lib/lp/code/model/gitrule.py'
> --- lib/lp/code/model/gitrule.py	2018-10-03 00:53:55 +0000
> +++ lib/lp/code/model/gitrule.py	2018-10-03 00:53:56 +0000
> @@ -48,7 +51,10 @@
>      events on Git repository rules.
>      """
>      if event.edited_fields:
> -        rule.date_last_modified = UTC_NOW
> +        user = IPerson(event.user)
> +        getUtility(IGitActivitySet).logRuleChanged(
> +            event.object_before_modification, rule, user)
> +        removeSecurityProxy(rule).date_last_modified = UTC_NOW

Both of these pushed up, thanks.

>  
>  
>  @implementer(IGitRule)


-- 
https://code.launchpad.net/~cjwatson/launchpad/git-activity-model/+merge/354399
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.