launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

I've applied most of your suggestions; thanks.

Diff comments:

> 
> === modified file 'lib/lp/code/model/gitref.py'
> --- lib/lp/code/model/gitref.py	2018-08-23 12:34:24 +0000
> +++ lib/lp/code/model/gitref.py	2018-09-25 18:05:37 +0000
> @@ -453,7 +475,10 @@
>  
>      @property
>      def commit_message_first_line(self):
> -        return self.commit_message.split("\n", 1)[0]
> +        if self.commit_message is not None:
> +            return self.commit_message.split("\n", 1)[0]
> +        else:
> +            return None

This makes GitRef more reliably snapshottable, which I discovered as a problem while working on this branch, and included as a separate commit (https://bazaar.launchpad.net/~cjwatson/launchpad/git-permissions-webservice-ref/revision/18791).  It could perhaps have been a separate MP, but was so small it was hardly worth the overhead.

>  
>      @property
>      def has_commits(self):


-- 
https://code.launchpad.net/~cjwatson/launchpad/git-permissions-webservice-ref/+merge/355608
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.