launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/genericise-cron.publish-ppa into lp:launchpad.

Commit message:
Make cron.publish-ppa take distro selection criteria as arguments.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/genericise-cron.publish-ppa/+merge/357123

This is live on production already.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/genericise-cron.publish-ppa into lp:launchpad.

=== modified file 'cronscripts/publishing/cron.publish-ppa'
--- cronscripts/publishing/cron.publish-ppa	2014-08-05 10:37:07 +0000
+++ cronscripts/publishing/cron.publish-ppa	2018-10-19 05:27:09 +0000
@@ -10,12 +10,8 @@
 
 LPCURRENT=`dirname $0`/../..
 
-# Publish Ubuntu PPAs.
-$LPCURRENT/scripts/process-accepted.py -v --ppa -d ubuntu
-$LPCURRENT/scripts/publish-distro.py -v --ppa -d ubuntu
-$LPCURRENT/scripts/publish-distro.py -v --private-ppa -d ubuntu
-
-# Publish PPAs for other distros.
-$LPCURRENT/scripts/process-accepted.py -v --ppa --all-derived
-$LPCURRENT/scripts/publish-distro.py -v --ppa --all-derived
-$LPCURRENT/scripts/publish-distro.py -v --private-ppa --all-derived
+for DISTRO_ARG in "$@"; do
+  $LPCURRENT/scripts/process-accepted.py -v --ppa $DISTRO_ARG
+  $LPCURRENT/scripts/publish-distro.py -v --ppa $DISTRO_ARG
+  $LPCURRENT/scripts/publish-distro.py -v --private-ppa $DISTRO_ARG
+done