launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/fix-checkRefPermissions-interface into lp:launchpad.

Commit message:
Fix the declaration of IGitAPI.checkRefPermissions to match reality.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/fix-checkRefPermissions-interface/+merge/357659

It doesn't seem to actually matter (no tests fail), but it's a lot less confusing when the interface is accurate.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/fix-checkRefPermissions-interface into lp:launchpad.

=== modified file 'lib/lp/code/interfaces/gitapi.py'
--- lib/lp/code/interfaces/gitapi.py	2018-10-18 16:43:14 +0000
+++ lib/lp/code/interfaces/gitapi.py	2018-10-22 19:29:20 +0000
@@ -68,7 +68,7 @@
             not yet supported.
         """
 
-    def checkRefPermissions(self, repository, ref_paths, user):
+    def checkRefPermissions(translated_paths, ref_paths, auth_params):
         """Return a list of ref rules for a `user` in a `repository` that
         match the input refs.