launchpad-reviewers team mailing list archive

[Tom Wardill <tom.wardill@xxxxxxxxxxxxx>]

Tom Wardill has proposed merging lp:~twom/launchpad/fix-git-activity-interface into lp:launchpad.

Commit message:
Fix interface for gitrepository

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~twom/launchpad/fix-git-activity-interface/+merge/358555

getPrecachedActivity takes **kwargs, not a named parameter.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~twom/launchpad/fix-git-activity-interface into lp:launchpad.

=== modified file 'lib/lp/code/interfaces/gitrepository.py'
--- lib/lp/code/interfaces/gitrepository.py	2018-11-05 18:05:08 +0000
+++ lib/lp/code/interfaces/gitrepository.py	2018-11-09 14:27:04 +0000
@@ -639,7 +639,7 @@
         :return: A `ResultSet` of `IGitActivity`.
         """
 
-    def getPrecachedActivity(changed_after=None):
+    def getPrecachedActivity(**kwargs):
         """Activity log entries are preloaded.
 
         :param changed_after: If supplied, only return entries for changes