← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cjwatson/launchpad/close-account-perms into lp:launchpad

 

Review: Approve code

I think we need to look over all Person FKs and work out what to do. The script has only been used a handful of times and then probably not for more than a decade, and it has weird stuff that bypasses audit trails, sets invalid questions to solved, wipes the audit trail in Account.status_comment, etc.

The port to Storm seems fine, but this can't go near production yet.
-- 
https://code.launchpad.net/~cjwatson/launchpad/close-account-perms/+merge/359773
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References