launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-git-permissions-personmerge-whitelist into lp:launchpad.

Commit message:
Drop GitRuleGrant.grantee whitelist from personmerge.  This is handled properly now.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/remove-git-permissions-personmerge-whitelist/+merge/359835
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/remove-git-permissions-personmerge-whitelist into lp:launchpad.

=== modified file 'lib/lp/registry/personmerge.py'
--- lib/lp/registry/personmerge.py	2018-10-05 15:35:34 +0000
+++ lib/lp/registry/personmerge.py	2018-11-29 13:53:37 +0000
@@ -768,10 +768,6 @@
         ('latestpersonsourcepackagereleasecache', 'maintainer'),
         # Obsolete table.
         ('branchmergequeue', 'owner'),
-        # This needs handling before we deploy the Git permissions model
-        # code, but can be ignored for the purpose of deploying the database
-        # tables.
-        ('gitrulegrant', 'grantee'),
         ]
 
     references = list(postgresql.listReferences(cur, 'person', 'id'))