launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/charms/trusty/rutabaga/squid-rsync-ids into lp:~canonical-launchpad-branches/charms/trusty/rutabaga/devel.

Commit message:
Tell rsyncd to use the proxy uid/gid when serving squid-logs.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/charms/trusty/rutabaga/squid-rsync-ids/+merge/359954

This is much simpler and IMO more sensible than the current hacks to run squid with umask 022 instead of its default of 027, and will allow dropping those hacks (which become even more awkward with later versions of Ubuntu, and I think would otherwise require sedding init scripts).
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/charms/trusty/rutabaga/squid-rsync-ids into lp:~canonical-launchpad-branches/charms/trusty/rutabaga/devel.

=== modified file 'templates/rutabaga-rsync.j2'
--- templates/rutabaga-rsync.j2	2016-07-05 14:54:01 +0000
+++ templates/rutabaga-rsync.j2	2018-11-30 20:25:25 +0000
@@ -7,6 +7,8 @@
   hosts allow = {{ log_hosts_allow }}
 
 [squid-logs]
+  uid = proxy
+  gid = proxy
   path = /var/log/squid3
   comment = Squid Logs
   list = false