launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> 
> === modified file 'lib/lp/code/model/gitref.py'
> --- lib/lp/code/model/gitref.py	2018-11-09 22:06:43 +0000
> +++ lib/lp/code/model/gitref.py	2018-11-29 12:18:57 +0000
> @@ -390,8 +414,11 @@
>              commits.append(parsed_commit)
>          return commits
>  
> -    def getLatestCommits(self, quantity=10, extended_details=False, user=None):
> -        commits = self.getCommits(self.commit_sha1, limit=quantity)
> +    def getLatestCommits(self, quantity=10, extended_details=False, user=None,
> +                         logger=None):
> +        commits = self.getCommits(
> +            self.commit_sha1, limit=quantity, handle_timeout=True,
> +            logger=logger)

I did this because it only had one non-test caller and that caller wanted handle_timeout=True.  I don't feel that strongly about it, though, so I've made it default to False and pulled the handle_timeout=True out to the caller (GitRefView.commit_infos).

>          if extended_details:
>              # XXX cjwatson 2016-05-09: Add support for linked bugtasks once
>              # those are supported for Git.


-- 
https://code.launchpad.net/~cjwatson/launchpad/git-ref-tolerate-slow-commit-info/+merge/359827
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.