launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/oops-revision into lp:launchpad.

Commit message:
Use 'revision' rather than 'revno' in OOPSes, now that python-oops-tools supports that.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/oops-revision/+merge/362143

This makes a bit more sense for Git.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/oops-revision into lp:launchpad.

=== modified file 'lib/lp/services/webapp/errorlog.py'
--- lib/lp/services/webapp/errorlog.py	2017-09-02 13:44:28 +0000
+++ lib/lp/services/webapp/errorlog.py	2019-01-23 17:06:08 +0000
@@ -282,9 +282,7 @@
         # What do we want in our reports?
         # Constants:
         self._oops_config.template['branch_nick'] = versioninfo.branch_nick
-        # XXX cjwatson 2016-09-14: This should really be 'revision', but
-        # that requires coordination with python-oops-tools.
-        self._oops_config.template['revno'] = versioninfo.revision
+        self._oops_config.template['revision'] = versioninfo.revision
         reporter = config[self._default_config_section].oops_prefix
         if section_name != self._default_config_section:
             reporter = '%s-%s' % (reporter, section_name)