← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~abrody/launchpad/rocketfuel-apt into lp:launchpad

 

I applaud the intent of rocketfuel-rm-evil-keys, but I don't think it's going to pull its weight as a permanent part of the codebase.  The number of people who run rocketfuel-setup (especially people who have run it since the xenial upgrade; anyone who ran it before that would have to recreate their container anyway) is tiny, and they're all people who are interested in Launchpad development.  Could you please remove it from this branch and instead post it to launchpad-dev@xxxxxxxxxxxxxxxxxxx after this branch lands?  If anything, I think that will get more attention than a new file being added to the codebase.
-- 
https://code.launchpad.net/~abrody/launchpad/rocketfuel-apt/+merge/362639
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abrody/launchpad/rocketfuel-apt into lp:launchpad.


References