launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/soyuz/interfaces/distroarchseries.py'
> --- lib/lp/soyuz/interfaces/distroarchseries.py	2019-01-14 14:21:36 +0000
> +++ lib/lp/soyuz/interfaces/distroarchseries.py	2019-01-14 14:21:36 +0000
> @@ -153,8 +154,8 @@
>          series.
>          """
>  
> -    def getPocketChroot(pocket, exact_pocket=False):
> -        """Return the PocketChroot for this distroarchseries and given pocket.
> +    def getPocketChroot(pocket, exact_pocket=False, image_type=None):
> +        """Return the PocketChroot for this series, pocket, and image type.

Worth documenting that BuildBaseImageType.CHROOT is the default?

>  
>          If exact_pocket is False, this follows pocket dependencies and finds
>          the chroot for the closest pocket that exists: for example, if no


-- 
https://code.launchpad.net/~cjwatson/launchpad/pocket-chroot-image-type/+merge/361734
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.