launchpad-reviewers team mailing list archive

[Daniel Manrique <daniel.manrique@xxxxxxxxxxxxx>]

Review: Approve

@roadmr cjwatson: lgtm but one question - why the json serializer and not yaml? I know johan/maxi picked yaml over json for sca for $REASONS
@roadmr (I think yaml could serialize some things that json couldn't or somesuch)
cjwatson roadmr: LP doesn't really need anything complicated, so I just went for the default in newer celery versions
cjwatson I haven't exhaustively checked but I suspect that we only use task results at all in the test suite

having uniformity (i.e. trying to have all services using either yaml or json) would be nice for superficial reasons but I don't see a problem with Launchpad making its own independent decisions and this should fit the bill nicely.

-- 
https://code.launchpad.net/~cjwatson/launchpad/celery-disable-pickle/+merge/364045
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/celery-disable-pickle into lp:launchpad.