launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> === modified file 'lib/lp/services/gpg/doc/gpg-signatures.txt'
> --- lib/lp/services/gpg/doc/gpg-signatures.txt	2012-06-29 08:40:05 +0000
> +++ lib/lp/services/gpg/doc/gpg-signatures.txt	2019-03-07 15:39:32 +0000
> @@ -164,7 +168,8 @@
>      >>> gpghandler.getVerifiedSignature(content)
>      Traceback (most recent call last):
>      ...
> -    GPGVerificationError: (7, 9, u'No public key')
> +    GPGKeyDoesNotExistOnServer: GPG key E192C0543B1BB2EB does not exist on the
> +    keyserver.

It's odd that this isn't a full fingerprint.

>  
>  Due to unpredictable behaviour between the production system and
>  the external keyserver, we have a resilient signature verifier,


-- 
https://code.launchpad.net/~cjwatson/launchpad/no-auto-key-retrieve/+merge/364100
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.