launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve

Looks good to me apart from these comments, so let me know when you've fixed them and I can land this.

Diff comments:

> === modified file 'lib/lp/archivepublisher/publishing.py'
> --- lib/lp/archivepublisher/publishing.py	2018-03-27 23:26:12 +0000
> +++ lib/lp/archivepublisher/publishing.py	2018-04-13 15:19:18 +0000
> @@ -1212,6 +1212,17 @@
>              except OSError as e:
>                  if e.errno != errno.ENOENT:
>                      raise
> +            cnf_dir = os.path.join(suite_dir, component, "cnf")
> +            try:
> +                for cnf_file in os.listdir(cnf_dir):
> +                    if dep11_file.startswith("Commands-"):

This should be cnf_file, not dep11_file.

> +                        cnf_path = os.path.join(
> +                            component, "cnf", cnf_file)
> +                        extra_files.add(remove_suffix(cnf_path))
> +                        extra_files.add(cnf_path)
> +            except OSError as e:
> +                if e.errno != errno.ENOENT:
> +                    raise
>          for architecture in all_architectures:
>              for contents_path in get_suffixed_indices(
>                      'Contents-' + architecture):


-- 
https://code.launchpad.net/~mvo/launchpad/add-cnf-metadata-to-release-file/+merge/343161
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.