launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> === modified file 'lib/lp/services/config/schema-lazr.conf'
> --- lib/lp/services/config/schema-lazr.conf	2019-03-13 16:12:42 +0000
> +++ lib/lp/services/config/schema-lazr.conf	2019-03-18 12:14:41 +0000
> @@ -1104,6 +1104,9 @@
>  # datatype: string
>  feature_flags_endpoint:
>  
> +# Default timeout for fetching remote URLs.

Worth a comment that most callsites override this?

> +urlfetch_timeout: 30
> +
>  [launchpad_session]
>  # The database connection string.
>  # datatype: pgconnection


-- 
https://code.launchpad.net/~cjwatson/launchpad/global-urlfetch-timeout/+merge/364669
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.