launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/pymacaroons-0.13.0 into lp:launchpad.

Commit message:
Upgrade to pymacaroons 0.13.0 and PyNaCl 1.3.0.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/pymacaroons-0.13.0/+merge/364733

I'd previously thought we couldn't get past PyNaCl 1.0.1 due to libsodium compatibility requirements, but it doesn't actually seem to be a problem.

The pymacaroons upgrade brings in support for the more compact macaroon v2 serialisation format, which I think we could reasonably start using in some places once this commit has been deployed on production.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/pymacaroons-0.13.0 into lp:launchpad.

=== modified file 'constraints.txt'
--- constraints.txt	2019-01-21 17:45:55 +0000
+++ constraints.txt	2019-03-19 09:45:15 +0000
@@ -323,8 +323,8 @@
 # lp1 Link against libgpgme-pthread for thread-safety.
 pygpgme==0.3+lp1
 pyinotify==0.9.4
-pymacaroons==0.9.2
-PyNaCl==1.0.1
+pymacaroons==0.13.0
+PyNaCl==1.3.0
 pyOpenSSL==17.5.0
 pystache==0.5.3
 python-dateutil==1.5