launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/test-errorlog-capture-oops into lp:launchpad.

Commit message:
Convert TestErrorReportingUtility to lp.testing.TestCase so that it declares the test "oopses" exchange during setup.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/test-errorlog-capture-oops/+merge/366435
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/test-errorlog-capture-oops into lp:launchpad.

=== modified file 'lib/lp/services/webapp/tests/test_errorlog.py'
--- lib/lp/services/webapp/tests/test_errorlog.py	2018-01-02 10:54:31 +0000
+++ lib/lp/services/webapp/tests/test_errorlog.py	2019-04-24 09:00:33 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2019 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Tests for error logging & OOPS reporting."""
@@ -45,6 +45,7 @@
     IUnloggedException,
     NoReferrerError,
     )
+from lp.testing import TestCase
 from lp.testing.layers import LaunchpadLayer
 
 
@@ -55,7 +56,7 @@
     """Used to test handling of exceptions in OOPS reports."""
 
 
-class TestErrorReportingUtility(testtools.TestCase):
+class TestErrorReportingUtility(TestCase):
 
     # want rabbit
     layer = LaunchpadLayer