← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~cjwatson/launchpad/more-memcached-size into lp:launchpad

 

Colin Watson has proposed merging lp:~cjwatson/launchpad/more-memcached-size into lp:launchpad.

Commit message:
Bump memcached memory size to two megabytes.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/more-memcached-size/+merge/366620

The defaults cause memcached 1.5.6 to complain that slab_chunk_max is larger than item_size_max. Since this is just for local development and testing, it's easiest to just increase the memory size to avoid this.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/more-memcached-size into lp:launchpad.
=== modified file 'configs/development/launchpad-lazr.conf'
--- configs/development/launchpad-lazr.conf	2019-04-23 12:30:16 +0000
+++ configs/development/launchpad-lazr.conf	2019-04-28 15:19:04 +0000
@@ -165,7 +165,7 @@
 verbose: False
 address: 127.0.0.1
 port: 11217
-memory_size: 1
+memory_size: 2
 
 [personalpackagearchive]
 root: /var/tmp/ppa/

=== modified file 'configs/testrunner/launchpad-lazr.conf'
--- configs/testrunner/launchpad-lazr.conf	2019-04-23 12:30:16 +0000
+++ configs/testrunner/launchpad-lazr.conf	2019-04-28 15:19:04 +0000
@@ -144,7 +144,7 @@
 # The test suite takes care of launching this as necessary.
 launch: false
 verbose: false
-memory_size: 1
+memory_size: 2
 address: 127.0.0.1
 # We want a different port to ensure we don't pick up stray memcached
 # processes spawned through some other mechanism.

=== modified file 'lib/lp/services/config/schema-lazr.conf'
--- lib/lp/services/config/schema-lazr.conf	2019-04-23 12:30:16 +0000
+++ lib/lp/services/config/schema-lazr.conf	2019-04-28 15:19:04 +0000
@@ -1449,7 +1449,7 @@
 verbose: false
 # Cache size in megabytes for local memcached instance.
 # datatype: integer
-memory_size: 1
+memory_size: 2
 # Address for local memcached instance to bind to.
 # datatype: ip_address_or_hostname
 address: 127.0.0.1


Follow ups