launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/bugs/doc/externalbugtracker-trac-lp-plugin.txt'
> --- lib/lp/bugs/doc/externalbugtracker-trac-lp-plugin.txt	2019-05-22 14:57:45 +0000
> +++ lib/lp/bugs/doc/externalbugtracker-trac-lp-plugin.txt	2019-06-07 22:10:19 +0000
> @@ -135,7 +135,8 @@
>      Traceback (most recent call last):
>        ...
>      BugTrackerAuthenticationError: http://example.com:
> -    401 Client Error: Unauthorized
> +    401 Client Error: Unauthorized for url:
> +    http://example.com/launchpad-auth/...

I'm not a massive fan of including potentially credentially-laden URLs in exception messages, but I suppose it's not too bad.

>  
>  
>  Current time


-- 
https://code.launchpad.net/~cjwatson/launchpad/requests-2.22.0/+merge/368580
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.