launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-lpreview into lp:launchpad.

Commit message:
Remove lpreview from sourcedeps.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/remove-lpreview/+merge/368835

Most of this is fairly obsolete, and even if it isn't, people can just as well install it as a local plugin without it being in the Launchpad tree.  (It also hasn't been ported to Breezy as far as I can see.)
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/remove-lpreview into lp:launchpad.

=== modified file 'database/sampledata/README'
--- database/sampledata/README	2019-05-22 14:57:45 +0000
+++ database/sampledata/README	2019-06-14 14:32:12 +0000
@@ -74,4 +74,4 @@
 
             bzr commit -m 'Added frotz to sampledata..."
             bzr push
-            bzr review-submit ...
+            bzr lp-propose-merge ...

=== modified file 'utilities/sourcedeps.cache'
--- utilities/sourcedeps.cache	2018-02-21 22:26:43 +0000
+++ utilities/sourcedeps.cache	2019-06-14 14:32:12 +0000
@@ -27,10 +27,6 @@
         492, 
         "cjwatson@xxxxxxxxxxxxx-20180221151136-cfapvzjpo8px3cue"
     ], 
-    "lpreview": [
-        23, 
-        "launchpad@xxxxxxxxxxxxxxxxx-20090720061538-euyh68ifavhy0pi8"
-    ], 
     "mailman": [
         977, 
         "launchpad@xxxxxxxxxxxxxxxxx-20130405041235-9ud0xancja2eefd7"

=== modified file 'utilities/sourcedeps.conf'
--- utilities/sourcedeps.conf	2018-02-21 22:26:43 +0000
+++ utilities/sourcedeps.conf	2019-06-14 14:32:12 +0000
@@ -14,7 +14,6 @@
 cscvs lp:~launchpad-pqm/launchpad-cscvs/devel;revno=433
 difftacular lp:~launchpad/difftacular/trunk;revno=6
 loggerhead lp:~loggerhead-team/loggerhead/trunk-rich;revno=492
-lpreview lp:~launchpad-pqm/bzr-lpreview/devel;revno=23
 mailman lp:~launchpad-pqm/mailman/2.1;revno=977
 old_xmlplus lp:~launchpad-pqm/dtdparser/trunk;revno=4
 pygettextpo lp:~launchpad-pqm/pygettextpo/trunk;revno=25