launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> === modified file 'lib/lp/snappy/model/snapbuildjob.py'
> --- lib/lp/snappy/model/snapbuildjob.py	2018-12-18 18:10:39 +0000
> +++ lib/lp/snappy/model/snapbuildjob.py	2019-06-19 10:53:29 +0000
> @@ -350,7 +350,6 @@
>                      raise ManualReview(
>                          "Package held for manual review on the store; "
>                          "cannot release it automatically.")

While this doesn't hurt, I think it's unnecessary caution.  If you look at SnapPushStatusHandler._process_state in SCA, every path that returns a 'url' field also returns a 'revision' field (although it may be None), including the manual review case.

> -                client.release(self.snapbuild, self.store_revision)
>              self.error_message = None
>          except self.retry_error_types:
>              raise


-- 
https://code.launchpad.net/~twom/launchpad/snap-release-intents/+merge/369028
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.