launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> === modified file 'lib/lp/scripts/garbo.py'
> --- lib/lp/scripts/garbo.py	2019-06-12 15:09:24 +0000
> +++ lib/lp/scripts/garbo.py	2019-06-12 15:09:24 +0000
> @@ -1567,9 +1567,10 @@
>      """A BulkPruner to remove old `LiveFSFile`s.
>  
>      We remove binary files attached to `LiveFSBuild`s that are more than
> -    `LiveFS.keep_binary_files_interval` old; these files are very large and
> -    are only useful for builds in progress.  Text files are typically small
> -    (<1MiB) and useful for retrospective analysis, so we preserve those
> +    `LiveFS.keep_binary_files_interval` old and that are not set as base
> +    images for a `DistroArchSeries`; these files are very large and are only
> +    useful for builds in progress.  Text files are typically small (<1MiB)
> +    and useful for retrospective analysis, so we preserve those
>      indefinitely.

Can you explain why, so we remember in the future?

>      """
>      target_table_class = LiveFSFile


-- 
https://code.launchpad.net/~cjwatson/launchpad/livefs-keep-base-images/+merge/368714
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.