launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #23833
[Merge] lp:~cjwatson/launchpad/snap-build-record-code into lp:launchpad
The proposal to merge lp:~cjwatson/launchpad/snap-build-record-code into lp:launchpad has been updated.
Description changed to:
This is annoying, but I don't see any other way to cope with privacy changes of code objects that have snaps attached to them without leaking information about old builds.
We shouldn't land this until https://code.launchpad.net/~cjwatson/launchpad/branch-delete-job/+merge/364907 and https://code.launchpad.net/~cjwatson/launchpad/git-repository-delete-job/+merge/364910 have landed, as it'll make deletions slower; and, assuming all of these are approved, we'll need to add SELECT and DELETE permissions for the snap-build-job user on public.snapbuild before landing this.
https://code.launchpad.net/~cjwatson/launchpad/db-snap-build-record-code/+merge/365355 is the corresponding database patch.
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/snap-build-record-code/+merge/365356
--
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/snap-build-record-code into lp:launchpad.
References