launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve

Could we have a test for the bug you're fixing with this MP, please?

Diff comments:

> 
> === modified file 'lib/lp/archivepublisher/tests/test_signing.py'
> --- lib/lp/archivepublisher/tests/test_signing.py	2019-08-27 09:40:34 +0000
> +++ lib/lp/archivepublisher/tests/test_signing.py	2019-08-27 15:56:13 +0000
> @@ -979,13 +979,14 @@
>          This should fall through to the first series,
>          as the second does not have keys.
>          """
> +        self.suite = "nokeys-distroseries"

Not a very realistic example, since "distroseries" isn't a valid pocket: try "nokeys-proposed".

>          first_series = self.factory.makeDistroSeries(
>              self.distro,
> -            name="existing-keys"
> +            name="existingkeys"
>              )
>          self.factory.makeDistroSeries(
>              self.distro,
> -            name="no-keys"
> +            name="nokeys"
>              )
>          # Each image in the tarball is signed.
>          self.setUpUefiKeys()


-- 
https://code.launchpad.net/~twom/launchpad/per-series-signing-keys/+merge/371891
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.