launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> 
> === modified file 'lib/lp/registry/tests/test_distributionmirror.py'
> --- lib/lp/registry/tests/test_distributionmirror.py	2018-01-02 10:54:31 +0000
> +++ lib/lp/registry/tests/test_distributionmirror.py	2019-09-02 14:15:40 +0000
> @@ -224,6 +227,15 @@
>          transaction.commit()
>          self.assertEqual(len(stub.test_emails), 1)
>  
> +    def test_permissions_for_resubmit(self):
> +        self.assertRaises(
> +            Unauthorized, getattr,  self.archive_mirror, 'resubmitForReview')
> +        login_as(self.archive_mirror.owner)
> +        self.archive_mirror.status = MirrorStatus.BROKEN
> +        self.archive_mirror.resubmitForReview()
> +        self.assertTrue(
> +            self.archive_mirror.status == MirrorStatus.PENDING_REVIEW)

self.assertEqual(MirrorStatus.PENDING_REVIEW, self.archive_mirror.status)

> +
>  
>  class TestDistributionMirrorSet(TestCase):
>      layer = LaunchpadFunctionalLayer


-- 
https://code.launchpad.net/~twom/launchpad/sometimes-mirrors-are-broken/+merge/372015
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.