launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> 
> === modified file 'lib/lp/soyuz/interfaces/distroarchseries.py'
> --- lib/lp/soyuz/interfaces/distroarchseries.py	2019-07-30 11:38:18 +0000
> +++ lib/lp/soyuz/interfaces/distroarchseries.py	2019-09-04 14:01:22 +0000
> @@ -216,6 +230,21 @@
>          this distro arch series.
>          """
>  
> +    def getFilter():
> +        """Get the filter for packages to build for this architecture, if any.
> +
> +        Packages are normally built for all available architectures, subject
> +        to any constraints in their `Architecture` field.  If a filter is
> +        set, then it applies the additional constraint that packages not
> +        included by the filter will not be built for this architecture.
> +        """

OK, renamed along with its siblings.

> +
> +    def isSourceIncluded(sourcepackagerelease):
> +        """Is this source package included in this distro arch series?
> +
> +        :param sourcepackagerelease: An `ISourcePackageRelease` to check.
> +        """

This was actually a mistake in the interface - the model already took an SPN, so I've corrected the interface to match.  I agree it doesn't matter very much either way though.

> +
>  
>  class IDistroArchSeriesModerate(Interface):
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/das-filter-model/+merge/372261
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.