launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:fix-bugtracker-html into launchpad:master.

Commit message:
Fix unbalanced tags in ProductBugTrackerWidget

If the project is part of a project group that has a bug tracker, then
there was a superfluous "</label>".  Amazingly, this has been wrong
since 2006 and nobody ever seems to have noticed; but it confuses
zope.testbrowser 5.x.

Since the new zope.testbrowser will catch this once we upgrade to it, I
didn't think it was worth adding a separate test.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/375400
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:fix-bugtracker-html into launchpad:master.

diff --git a/lib/lp/app/widgets/product.py b/lib/lp/app/widgets/product.py
index 346f805..b4b2f40 100644
--- a/lib/lp/app/widgets/product.py
+++ b/lib/lp/app/widgets/product.py
@@ -179,7 +179,7 @@ class ProductBugTrackerWidget(LaunchpadRadioWidget):
             projectgroup_bugtracker_caption = "Somewhere else"
         else:
             projectgroup_bugtracker_caption = structured(
-                'In the %s bug tracker (<a href="%s">%s</a>)</label>',
+                'In the %s bug tracker (<a href="%s">%s</a>)',
                 projectgroup.displayname,
                 canonical_url(projectgroup.bugtracker),
                 projectgroup.bugtracker.title).escapedtext