launchpad-reviewers team mailing list archive

[Robert C Jennings <robert.jennings@xxxxxxxxxxxxx>]

Robert C Jennings has proposed merging lp:~rcj/launchpad-buildd/lp1852518 into lp:launchpad-buildd.

Commit message:
LXD: Create dm-X devices to address kpartx hangs (LP: #1852518)

On focal kpartx looks for dm devices and hangs in their absense.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1852518 in launchpad-buildd: "livecd-rootfs focal hangs during kpartx (ubuntu-cpc project)"
  https://bugs.launchpad.net/launchpad-buildd/+bug/1852518

For more details, see:
https://code.launchpad.net/~rcj/launchpad-buildd/lp1852518/+merge/375529
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rcj/launchpad-buildd/lp1852518 into lp:launchpad-buildd.

=== modified file 'debian/changelog'
--- debian/changelog	2019-11-06 11:12:41 +0000
+++ debian/changelog	2019-11-14 02:24:35 +0000
@@ -1,3 +1,9 @@
+launchpad-buildd (181) UNRELEASED; urgency=medium
+
+  * LXD: Create dm-X devices to address kpartx hangs (LP: #1852518)
+
+ -- Robert C Jennings <robert.jennings@xxxxxxxxxxxxx>  Wed, 13 Nov 2019 18:07:32 -0800
+
 launchpad-buildd (180) xenial; urgency=medium
 
   * No-change release to work around production upgrade problem.

=== modified file 'lpbuildd/target/lxd.py'
--- lpbuildd/target/lxd.py	2019-06-09 07:49:21 +0000
+++ lpbuildd/target/lxd.py	2019-11-14 02:24:35 +0000
@@ -446,6 +446,13 @@
                 ["mknod", "-m", "0660", "/dev/loop%d" % minor,
                  "b", "7", str(minor)])
 
+        # Create dm-# devices.  On focal kpartx looks for dm devices and hangs
+        # in their absense.
+        for minor in range(8):
+            self.run(
+                ["mknod", "-m", "0660", "/dev/dm-%d" % minor,
+                 "b", "251", str(minor)])
+
         # XXX cjwatson 2017-09-07: With LXD < 2.2 we can't create the
         # directory until the container has started.  We can get away with
         # this for the time being because snapd isn't in the buildd chroots.