launchpad-reviewers team mailing list archive

[Ioana Lasc <ioana.lasc@xxxxxxxxxxxxx>]

Thanks Colin! 

I backed out out the RepoSet level test and added one on the Webservice as recommended. 

I'm still confused as to why this exception surfaces as a 500 html code instead of 400. 

I wonder is there another layer between Snapcraft and LP that converts the LP 400 into a Snapcraft 500 error code while passing the LP exception message ?
 
With the Unit Test added at Webservice I'm getting this back from the endpoint: 

HTTP/1.1 400 Bad Request
Content-Length: 8
Content-Security-Policy: frame-ancestors 'self';
Content-Type: text/plain;charset=utf-8
Strict-Transport-Security: max-age=15552000
Vary: Accept
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Launchpad-Revision: bde8fcb9c6ce57fa73001a9bd2a4e51cdb0313b7
X-Lazr-Notifications: []
X-Xss-Protection: 1; mode=block
-- 
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/375614
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:bug-1852482 into launchpad:master.