launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:message-fix-for-package-filter into launchpad:master.

Commit message:
Small fix for "No matching package for ''." message on PPAs with no packages

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #513085 in Launchpad itself: "PPA with no packages says "No matching package for ''.""
  https://bugs.launchpad.net/launchpad/+bug/513085

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/377006
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:message-fix-for-package-filter into launchpad:master.

diff --git a/lib/lp/soyuz/templates/archive-index.pt b/lib/lp/soyuz/templates/archive-index.pt
index 05cfdd3..9a83a85 100644
--- a/lib/lp/soyuz/templates/archive-index.pt
+++ b/lib/lp/soyuz/templates/archive-index.pt
@@ -271,7 +271,7 @@ sudo apt-get update
 
         <div id="empty-result"
              tal:define="name_filter view/specified_name_filter|nothing"
-             tal:condition="not: batch">
+             tal:condition="python: not batch and name_filter">
           No matching package for '<tal:name_filter replace="name_filter" />'.
         </div>
 
diff --git a/lib/lp/soyuz/templates/archive-macros.pt b/lib/lp/soyuz/templates/archive-macros.pt
index 845eabf..a51b8c9 100644
--- a/lib/lp/soyuz/templates/archive-macros.pt
+++ b/lib/lp/soyuz/templates/archive-macros.pt
@@ -143,7 +143,7 @@ div.package-details {
 
     <div id="empty-result"
             tal:define="name_filter view/specified_name_filter|nothing"
-            tal:condition="not: batch">
+            tal:condition="python: not batch and name_filter">
       No matching package for '<tal:name_filter replace="name_filter" />'.
     </div>