launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:oops-report-test-errors into launchpad:master.

Commit message:
Fixing test errors when accessing person's name for OOPS reports

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/377039

Fix for the following tests:
xx-opstats
xx-soft-timeout
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:oops-report-test-errors into launchpad:master.

diff --git a/lib/lp/services/webapp/errorlog.py b/lib/lp/services/webapp/errorlog.py
index ecb53e3..ad63464 100644
--- a/lib/lp/services/webapp/errorlog.py
+++ b/lib/lp/services/webapp/errorlog.py
@@ -26,11 +26,11 @@ from zope.event import notify
 from zope.exceptions.exceptionformatter import format_exception
 from zope.interface import implementer
 from zope.publisher.interfaces.xmlrpc import IXMLRPCRequest
+from zope.security.proxy import removeSecurityProxy
 from zope.traversing.namespace import view
 
 from lp.app import versioninfo
 from lp.layers import WebServiceLayer
-from lp.registry.interfaces.person import IPerson
 from lp.services.config import config
 from lp.services.messaging import rabbit
 from lp.services.timeline.requesttimeline import get_request_timeline
@@ -181,7 +181,8 @@ def attach_http_request(report, context):
     principal = getattr(request, 'principal', missing)
 
     person = (
-        principal.person if ILaunchpadPrincipal.providedBy(principal)
+        removeSecurityProxy(principal.person)
+        if ILaunchpadPrincipal.providedBy(principal)
         else None)
     if person is not None:
         login = person.name