launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:macaroon-secret-key-cfg-explanation into launchpad:master.

Commit message:
- Adding a comment to help configure macaroon secret key for development
- Adding config section to run diff processing job

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/377304

Small improvements to make local development easier
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:macaroon-secret-key-cfg-explanation into launchpad:master.

diff --git a/lib/lp/services/config/schema-lazr.conf b/lib/lp/services/config/schema-lazr.conf
index 0e778f9..83080c9 100644
--- a/lib/lp/services/config/schema-lazr.conf
+++ b/lib/lp/services/config/schema-lazr.conf
@@ -1141,7 +1141,8 @@ min_legitimate_karma: 0
 min_legitimate_account_age: 0
 
 # Secret key for macaroons used to grant permissions to various internal
-# components of Launchpad.
+# components of Launchpad. Any random string of a
+# reasonable size (64 characters?) is ok
 internal_macaroon_secret_key: none
 
 [launchpad_session]
@@ -2096,6 +2097,10 @@ module: lp.registry.interfaces.productjob
 dbuser: product-job
 crontab_group: MAIN
 
+[IUpdatePreviewDiffJobSource]
+module: lp.code.interfaces.branchmergeproposal
+dbuser: merge-proposal-jobs
+
 [IWebhookDeliveryJobSource]
 module: lp.services.webhooks.interfaces
 dbuser: webhookrunner