launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:db-oci-git-indexes into launchpad:db-devel with ~cjwatson/launchpad:db-oci-git as a prerequisite.

Commit message:
Recreate GitRepository indexes for SPN/OCIPN

Requested reviews:
  Stuart Bishop (stub): db
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1847444 in Launchpad itself: "Support OCI image building"
  https://bugs.launchpad.net/launchpad/+bug/1847444

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377626

Previously we had a variety of indexes including (distribution, sourcepackagename) with non-NULL distribution but omitting the condition that sourcepackagename is also non-NULL.  Replace each of these with a pair of indexes, one for non-NULL sourcepackagename and one for non-NULL ociprojectname.

This can be applied hot by adding CONCURRENTLY.

LP: #1847444

(I split this out from db-oci-git to allow cold/hot patch splitting.)
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:db-oci-git-indexes into launchpad:db-devel.

diff --git a/database/schema/patch-2210-08-2.sql b/database/schema/patch-2210-08-2.sql
new file mode 100644
index 0000000..03ea785
--- /dev/null
+++ b/database/schema/patch-2210-08-2.sql
@@ -0,0 +1,77 @@
+-- Copyright 2019-2020 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+-- Create/replace indexes.  Previously we had a variety of indexes including
+-- (distribution, sourcepackagename) with non-NULL distribution but omitting
+-- the condition that sourcepackagename is also non-NULL.  Replace each of
+-- these with a pair of indexes, one for non-NULL sourcepackagename and one
+-- for non-NULL ociprojectname.
+
+CREATE UNIQUE INDEX gitrepository__owner__distribution__spn__name__key
+    ON GitRepository (owner, distribution, sourcepackagename, name)
+    WHERE distribution IS NOT NULL AND sourcepackagename IS NOT NULL;
+CREATE UNIQUE INDEX gitrepository__owner__distribution__ocipn__name__key
+    ON GitRepository (owner, distribution, ociprojectname, name)
+    WHERE distribution IS NOT NULL AND ociprojectname IS NOT NULL;
+DROP INDEX old__gitrepository__owner__distribution__sourcepackagename__name__key;
+
+CREATE UNIQUE INDEX gitrepository__distribution__spn__target_default__key
+    ON GitRepository (distribution, sourcepackagename)
+    WHERE
+        distribution IS NOT NULL AND sourcepackagename IS NOT NULL
+        AND target_default;
+CREATE UNIQUE INDEX gitrepository__distribution__ocipn__target_default__key
+    ON GitRepository (distribution, ociprojectname)
+    WHERE
+        distribution IS NOT NULL AND ociprojectname IS NOT NULL
+        AND target_default;
+DROP INDEX old__gitrepository__distribution__spn__target_default__key;
+
+CREATE UNIQUE INDEX gitrepository__owner__distribution__spn__owner_default__key
+    ON GitRepository (owner, distribution, sourcepackagename)
+    WHERE
+        distribution IS NOT NULL AND sourcepackagename IS NOT NULL
+        AND owner_default;
+CREATE UNIQUE INDEX gitrepository__owner__distribution__ocipn__owner_default__key
+    ON GitRepository (owner, distribution, ociprojectname)
+    WHERE
+        distribution IS NOT NULL AND ociprojectname IS NOT NULL
+        AND owner_default;
+DROP INDEX old__gitrepository__owner__distribution__spn__owner_default__key;
+
+CREATE INDEX gitrepository__distribution__spn__date_last_modified__idx
+    ON GitRepository (distribution, sourcepackagename, date_last_modified)
+    WHERE distribution IS NOT NULL AND sourcepackagename IS NOT NULL;
+CREATE INDEX gitrepository__distribution__ocipn__date_last_modified__idx
+    ON GitRepository (distribution, ociprojectname, date_last_modified)
+    WHERE distribution IS NOT NULL AND ociprojectname IS NOT NULL;
+DROP INDEX old__gitrepository__distribution__spn__date_last_modified__idx;
+
+CREATE INDEX gitrepository__distribution__spn__id__idx
+    ON GitRepository (distribution, sourcepackagename, id)
+    WHERE distribution IS NOT NULL AND sourcepackagename IS NOT NULL;
+CREATE INDEX gitrepository__distribution__ocipn__id__idx
+    ON GitRepository (distribution, ociprojectname, id)
+    WHERE distribution IS NOT NULL AND ociprojectname IS NOT NULL;
+DROP INDEX old__gitrepository__distribution__spn__id__idx;
+
+CREATE INDEX gitrepository__owner__distribution__spn__date_last_modified__idx
+    ON GitRepository (
+        owner, distribution, sourcepackagename, date_last_modified)
+    WHERE distribution IS NOT NULL AND sourcepackagename IS NOT NULL;
+CREATE INDEX gitrepository__owner__distribution__ocipn__date_last_modified__idx
+    ON GitRepository (owner, distribution, ociprojectname, date_last_modified)
+    WHERE distribution IS NOT NULL AND ociprojectname IS NOT NULL;
+DROP INDEX old__gitrepository__owner__distribution__spn__date_last_modified__idx;
+
+CREATE INDEX gitrepository__owner__distribution__spn__id__idx
+    ON GitRepository (owner, distribution, sourcepackagename, id)
+    WHERE distribution IS NOT NULL AND sourcepackagename IS NOT NULL;
+CREATE INDEX gitrepository__owner__distribution__ocipn__id__idx
+    ON GitRepository (owner, distribution, ociprojectname, id)
+    WHERE distribution IS NOT NULL AND ociprojectname IS NOT NULL;
+DROP INDEX old__gitrepository__owner__distribution__spn__id__idx;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 08, 2);