launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

I'm sorry this got a bit too big. Let me give a brief explanation of the changes here:

- Renaming of current (I)ArchiveSigningKey to (I)ArchiveGPGSigningKey to avoid confusion (this increased a bit the MP size, but no logic was changed regarding this part; only renaming the classes);

- On lp.services.signing, a "proxy" class to call lp-signing's REST API was created, with a test helper to mock `requests` using `responses` module;

- Still on lp.services.signing, 2 new database models were added (I'll open the MP for the migration SQL script soon): one to represent the signing key itself (SigningKey), and another to represent the link between the signing key and archive/distro-series (ArchiveSigningKey). Both models have helpers to interact with lp-signing's REST API using our "proxy" class;

- On lp.archivepublisher.signing, the logic that was not directly related to running signing commands and managing the keys on the filesystem was moved to a `BaseSigningUpload` class, and two concrete implementations were created: `LocalSigningUpload` (the current implementation, untouched) and `SigningServiceUpload` (using lp-signing and the 2 models created at lp.services.signing);

- On lp.archivepublisher.signing, the SigningUpload class (which is used today, and basically reflects what will be LocalSigningUpload) is now just a __new__ method deciding to build either `LocalSigningUpload` or `SigningServiceUpload` instances, depending on what is set for the flag 'lp.services.signing.enabled' (which defaults to False, so we keep the current behavior);

- On lp.archivepublisher.tests.test_signing, there are 2 test classes, each one testing one of the implementations of SigningUpload. Promoting tests to a superclass wouldn't be that simple (nor easily readable for future developers), so there are several testes quite similar between the two test classes.
-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/378364
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:lp-signing-integration into launchpad:master.