launchpad-reviewers team mailing list archive

Thread
Date

[Merge] ~cjwatson/launchpad:tour-git into launchpad:master

To: mp+378828@xxxxxxxxxxxxxxxxxx
From: Colin Watson <cjwatson@xxxxxxxxxxxxx>
Date: Mon, 10 Feb 2020 16:42:31 -0000
Reply-to: mp+378828@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Colin Watson has proposed merging ~cjwatson/launchpad:tour-git into launchpad:master.

Commit message:
Mention Git hosting in the tour

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378828

Launchpad has had Git hosting for some years now, so we really should at least mention it in a few appropriate places in the tour.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:tour-git into launchpad:master.

diff --git a/lib/lp/app/tour/branch-hosting-tracking b/lib/lp/app/tour/branch-hosting-tracking
index f67faea..6709c7f 100644
--- a/lib/lp/app/tour/branch-hosting-tracking
+++ b/lib/lp/app/tour/branch-hosting-tracking
@@ -2,7 +2,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml"; lang="en-US">
 <head>
     <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
-    <meta content="Canonical Launchpad Tour - You want to ensure that anybody who is interested can contribute code to your project, in a simple way, with full version control. And of course, you also want to maintain strict control of the people who can actually land code in your development trunk. Launchpad, together with Bazaar, give you infinite hosting for contributions while still preserving tight control over your core codebase." name="description"/>
+    <meta content="Canonical Launchpad Tour - You want to ensure that anybody who is interested can contribute code to your project, in a simple way, with full version control. And of course, you also want to maintain strict control of the people who can actually land code in your development trunk. Launchpad, together with Git or Bazaar, give you infinite hosting for contributions while still preserving tight control over your core codebase." name="description"/>
     <meta content="canonical, launchpad, tour" name="keywords"/>
     <meta content="en-US" name="language"/>
     <title>Launchpad tour</title>
@@ -37,14 +37,14 @@
                 <img src="images/hosting/main-image.jpg" alt="Collaborate with free software communities." />
             </p>
             <p class="intro-text">
-                <strong>Launchpad and Bazaar make it easy for anyone to get your project's code, make their own changes with full version control, and then propose their work for merging back into your trunk.</strong>
+                <strong>Launchpad makes it easy for anyone to get your project's code using Git or Bazaar, make their own changes with full version control, and then propose their work for merging back into your trunk.</strong>
             </p>
 
             <p class="intro-text">
                 Full control of who can land code in your project's trunk remains with you. And thanks to public code reviews, you can share the work of vetting proposed changes.
             </p>
             <p class="intro-text">
-                From experimental lines of development by entirely new contributors, to your official trunk, all code related to your project &mdash; whether hosted on Launchpad or elsewhere, even in Git, Subversion or CVS &mdash; is catalogued and can be downloaded with just a few key strokes.
+                From experimental lines of development by entirely new contributors, to your official trunk, all code related to your project &mdash; whether hosted on Launchpad or elsewhere, even in Subversion or CVS &mdash; is catalogued and can be downloaded with just a few key strokes.
             </p>
             <div id="link-holder"><a href="https://code.launchpad.net/";>Visit Launchpad Code &gt;</a><br /><a href="https://launchpad.net/projects/+new";>Add your project to Launchpad &gt;</a></div>
         </div>
@@ -67,7 +67,7 @@
                         <p class="screen-holder">
                             <img src="images/hosting/1.png" alt="Drive-by contributions" />                        </p>
                         <p>
-                            With Launchpad and Bazaar, contributors can create their own branch of your code, make their changes and then push it all back up to Launchpad to be listed right alongside your official branches.</p><br />
+                            With Launchpad, contributors can create their own branch of your code using Git or Bazaar, make their changes and then push it all back up to Launchpad to be listed right alongside your official branches.</p><br />
                        <p> And because they never touch your trunk they don&rsquo;t need to ask for commit access.</p><br />
                         <p>So, with no extra effort on your part new contributors can submit code to your project and propose it for merging into your trunk.</p>
                     </div>
@@ -98,7 +98,7 @@
                             <img src="images/hosting/3.png" alt="Working on a fix for a bug tracked in Launchpad?" />
                         </p>
                         <p>
-                            Develop your fix in a Bazaar branch and link it to the bug report. Anyone interested in the bug can track your progress and get access to your fix with a single command.
+                            Develop your fix in a Git or Bazaar branch and link it to the bug report. Anyone interested in the bug can track your progress and get access to your fix with a single command.
 </p><p>
 In effect, your branch becomes a living patch: the very latest version of your code is always available as direct link from the bug report.
                         </p>
@@ -109,7 +109,7 @@ In effect, your branch becomes a living patch: the very latest version of your c
                         <p class="screen-holder">
                             <img src="images/hosting/4.png" alt="Team branches" />                        </p>
                         <p>
-Thanks to Bazaar&rsquo;s workflow flexibility, all team members can commit to a centrally hosted branch, while anyone can still create their own separate line of development with full version control.
+All team members can commit to a centrally hosted branch, while anyone can still create their own separate line of development with full version control.
 
 
                         </p>
diff --git a/lib/lp/app/tour/index b/lib/lp/app/tour/index
index d9786ec..22fbd24 100644
--- a/lib/lp/app/tour/index
+++ b/lib/lp/app/tour/index
@@ -80,17 +80,17 @@
                     </div>
                     <div class="block odd">
                         <h3><a href="branch-hosting-tracking">Code hosting and review</a></h3>
-                        <h4>Democratise your code using Bazaar with Launchpad.</h4>
+                        <h4>Democratise your code using version control with Launchpad.</h4>
                         <p class="screen-holder">
                             <img src="images/code-screenshot.png" alt="Code hosting and tracking" />
                         </p>
                         <p>
 
-                         Launchpad and <a href="http://bazaar-vcs.org/";>Bazaar</a> distributed versional control strip away the barriers to contributing to your project. In just a few key strokes anyone can create their own local branch of your trunk with full version control.<br /><br />
+                         Launchpad and <a href="https://git-scm.com/";>Git</a> or <a href="http://bazaar.canonical.com/";>Bazaar</a> distributed version control strip away the barriers to contributing to your project. In just a few key strokes anyone can create their own local branch of your trunk with full version control.<br /><br />
 
                          When they're ready, they can upload their branch to Launchpad and propose it for merging back into your trunk. Code review &mdash; by web and email &mdash; gives you a public forum to discuss and approve or reject the merge.<br /><br />
 
-                         You can even use Launchpad to import Git, CVS and Subversion repositories into Bazaar branches.
+                         You can even use Launchpad to mirror Git repositories, or to import Git, CVS and Subversion repositories into Bazaar branches.
                         </p>
                         <p style="float: right;"><a href="branch-hosting-tracking" accesskey="f" tabindex="4">More about code hosting and review &gt;</a></p>
                         </ul>
diff --git a/lib/lp/app/tour/join-launchpad b/lib/lp/app/tour/join-launchpad
index dfb91c3..147f187 100644
--- a/lib/lp/app/tour/join-launchpad
+++ b/lib/lp/app/tour/join-launchpad
@@ -83,7 +83,7 @@ Launchpad is free to use for <a href="https://help.launchpad.net/Legal/ProjectLi
                            Your project can use any or all of Launchpad's applications:</p><br />
                    			<ul>
 				                  <li><strong><a href="bugs">Bug tracking</a>:</strong> across project and tool boundaries</li>
-				                  <li><strong><a href="branch-hosting-tracking">Code hosting and review</a>:</strong> open up to drive-by contributions with Bazaar branch hosting/mirroring and imports from git, Subversion and CVS.</li>
+				                  <li><strong><a href="branch-hosting-tracking">Code hosting and review</a>:</strong> open up to drive-by contributions with Git or Bazaar hosting and imports from Git, Subversion and CVS.</li>
 				                  <li><strong><a href="translation">Web-based translation</a>:</strong> make your software available to a global audience with help from Launchpad's 35,000 translators.</li>
 				                  <li><strong><a href="ppa">Ubuntu package building and hosting</a>:</strong> use your Personal Package Archives to distribute software, with updates, to Ubuntu users.</li>
 				                  <li><strong><a href="community">Mailing lists and teams</a>:</strong> hassle-free mailing list hosting and easy role delegation through teams.</li>

Follow ups

Re: [Merge] ~cjwatson/launchpad:tour-git into launchpad:master
From: Colin Watson, 2020-02-19
Re: [Merge] ~cjwatson/launchpad:tour-git into launchpad:master
From: Tom Wardill, 2020-02-19