launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/meta-lp-deps/python-tdb into lp:meta-lp-deps.

Commit message:
Depend on python-tdb, used by bzr-git and bzr-svn.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1757563 in Launchpad itself: "Code imports have undeclared dependency on python-tdb"
  https://bugs.launchpad.net/launchpad/+bug/1757563

For more details, see:
https://code.launchpad.net/~cjwatson/meta-lp-deps/python-tdb/+merge/378925

I thought about adding a new launchpad-codeimport-dependencies package; but I'm currently working on rearranging Launchpad's virtualenv to avoid system-site-packages, and this is simpler if all of Launchpad's Python dependencies are installed on all deployment targets.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/meta-lp-deps/python-tdb into lp:meta-lp-deps.

=== modified file 'debian/changelog'
--- debian/changelog	2019-10-11 22:23:10 +0000
+++ debian/changelog	2020-02-11 22:01:19 +0000
@@ -2,6 +2,7 @@
 
   * Remove dependency on python-tickcount; Launchpad no longer uses it.
   * Remove developer dependency on bzr-pqm; Launchpad is hosted in git now.
+  * Depend on python-tdb, used by bzr-git and bzr-svn (LP: #1757563).
 
  -- Colin Watson <cjwatson@xxxxxxxxxx>  Fri, 11 Oct 2019 23:21:35 +0100
 

=== modified file 'debian/control'
--- debian/control	2019-10-11 22:23:10 +0000
+++ debian/control	2020-02-11 22:01:19 +0000
@@ -25,6 +25,7 @@
   python-convoy, virtualenv | python-virtualenv (<< 1.11.6),
   libsodium-dev, libffi-dev, libssl-dev,
   libxml2-dev, libxslt1-dev,
+  python-tdb,
   ${misc:Depends}
 Recommends: launchpad-database-dependencies (= ${source:Version})
 Suggests: