launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~pappacena/launchpad:https-mirrors into launchpad:master

To: "Thiago F. Pappacena" <pappacena@xxxxxxxxx>
From: "Thiago F. Pappacena" <pappacena@xxxxxxxxx>
Date: Wed, 19 Feb 2020 21:13:52 -0000
In-reply-to: <158203299370.14759.4358467071020531407.codereview@soybean.canonical.com>
Reply-to: mp+379387@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I think it's in a good state for a review now, cjwatson. It's including:

- Brody's work to add the new fields
- The changes on prober to deal with HTTPS (using treq), including proxy (using ProxyAgent) and dealing with invalid certificates (both generic SSL errors and validation errors, like DNS mismatches).
-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/379387
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:https-mirrors into launchpad:master.

References

Re: [Merge] ~pappacena/launchpad:https-mirrors into launchpad:master
From: Thiago F. Pappacena, 2020-02-18