launchpad-reviewers team mailing list archive

[Tom Wardill <tom.wardill@xxxxxxxxxxxxx>]

Tom Wardill has proposed merging ~twom/launchpad:drop-not-null-on-git-path into launchpad:db-devel.

Commit message:
Just drop the NOT NULL on OCIRecipe.git_path

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/380048

We can't do this and add the constraint at the same time, it needs a code deploy between.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:drop-not-null-on-git-path into launchpad:db-devel.

diff --git a/database/schema/patch-2210-08-4.sql b/database/schema/patch-2210-08-4.sql
index 4656bb7..c2ca3fb 100644
--- a/database/schema/patch-2210-08-4.sql
+++ b/database/schema/patch-2210-08-4.sql
@@ -3,6 +3,4 @@
 
 ALTER TABLE OCIRecipe ALTER COLUMN git_path DROP NOT NULL;
 
-ALTER TABLE OCIRecipe ADD CONSTRAINT consistent_git_ref CHECK ((git_repository IS NULL) = (git_path IS NULL));
-
 INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 08, 4);