launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

MP for dependencies repository: https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies/+merge/380122

Diff comments:

> diff --git a/.gitignore b/.gitignore
> index fb9d39c..d35921f 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -16,3 +16,4 @@ parts
>  tags
>  TAGS
>  turnip/version_info.py
> +.idea

Ignoring JetBrain / pycharm project files

> diff --git a/Makefile b/Makefile
> index c43f2ee..fd37a2f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -49,7 +49,7 @@ endif
>  	 echo "allow_hosts = ''"; \
>  	 echo 'find_links = file://$(realpath $(PIP_SOURCE_DIR))/') \
>  		>$(ENV)/.pydistutils.cfg
> -	$(VIRTUALENV) --never-download $(ENV)
> +	$(VIRTUALENV) $(VENV_ARGS) --never-download $(ENV)

Making it easier to build python3 envs with `VENV_ARGS="-p python3" make bootstrap`

>  	$(PIP) install $(PIP_ARGS) -r bootstrap-requirements.txt
>  	$(PIP) install $(PIP_ARGS) -c requirements.txt \
>  		-e '.[test,deploy]'


-- 
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/380116
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip:python3-simple-deps-upgrade into turnip:master.