launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~pappacena/launchpad:change-override-log into launchpad:master

To: "Thiago F. Pappacena" <pappacena@xxxxxxxxx>
From: Colin Watson <cjwatson@xxxxxxxxxxxxx>
Date: Thu, 05 Mar 2020 16:40:10 -0000
In-reply-to: <158336159566.11468.16230232165774816577.codereview@wampee.canonical.com>
Reply-to: mp+380252@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

This looks like broadly the right sort of direction.  The main thing that I think needs to change is to explicitly pass the principal down from the caller (using @call_with(user=REQUEST_USER) or similar in the interface declaration) rather than picking out the principal in model code.
-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/380252
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:change-override-log into launchpad:master.

References

Re: [Merge] ~pappacena/launchpad:change-override-log into launchpad:master
From: Thiago F. Pappacena, 2020-03-04