launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/turnip:reverting-pygit-dep-version into turnip:master.

Commit message:
Downgrading pycparser to comply with pygit dependency of pycparser<2.18.

pycparser was mistakenly upgraded previously, and `make check` didn't warn about the missing dependency - so, CI allowed the merge. This dependency was only checked at runtime when running `make run-api`. To avoid future problems, we are adding `pip check` as a step when running `make check`.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/380546

Dependencies MP: https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies/+merge/380545
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip:reverting-pygit-dep-version into turnip:master.

diff --git a/Makefile b/Makefile
index fd37a2f..c514366 100644
--- a/Makefile
+++ b/Makefile
@@ -75,7 +75,10 @@ lint: $(ENV)
 	@$(FLAKE8) --exclude=__pycache__,version_info.py turnip
 	$(PYTHON) setup.py check --restructuredtext --strict
 
-check: test lint
+pip-check: $(ENV)
+	$(PIP) check
+
+check: pip-check test lint
 
 run-api: $(ENV)
 	$(PSERVE) api.ini --reload
diff --git a/requirements.txt b/requirements.txt
index c66347c..e81dffb 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -30,7 +30,7 @@ PasteDeploy==2.1.0
 pbr==5.4.4
 pep8==1.5.7
 pyasn1==0.4.8
-pycparser==2.19
+pycparser==2.17
 pycrypto==2.6.1
 pyflakes==0.8.1
 pygit2==0.27.4