launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/canonical-mojo-specs/snap-proxy-snapstorage into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.

Commit message:
snap-proxy: Allow storage.snapcraftcontent.com.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/canonical-mojo-specs/snap-proxy-snapstorage/+merge/381094
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/canonical-mojo-specs/snap-proxy-snapstorage into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.

=== modified file 'lp/mojo-lp-snap-proxy/production/deploy'
--- lp/mojo-lp-snap-proxy/production/deploy	2019-11-19 06:30:31 +0000
+++ lp/mojo-lp-snap-proxy/production/deploy	2020-03-24 10:26:19 +0000
@@ -94,9 +94,12 @@
                         # classic snaps.
                         162.213.33.196, 162.213.33.200, 162.213.33.233,
                         91.189.92.19, 91.189.92.20, 91.189.92.38, 91.189.92.41,
-                        # public.apps.ubuntu.com, used by snapcraft to fetch
-                        # the core snap for builds of classic snaps.
+                        # public.apps.ubuntu.com/storage.snapcraftcontent.com,
+                        # used by snapcraft to fetch the core snap for
+                        # builds of classic snaps.
                         162.213.33.91, 162.213.33.92,
+                        162.213.33.43, 162.213.33.81, 162.213.33.128,
+                        162.213.33.220,
                         # kernel.ubuntu.com, used by some developers to
                         # fetch code.
                         91.189.94.216,

=== modified file 'lp/mojo-lp-snap-proxy/qastaging/deploy'
--- lp/mojo-lp-snap-proxy/qastaging/deploy	2019-11-19 06:30:31 +0000
+++ lp/mojo-lp-snap-proxy/qastaging/deploy	2020-03-24 10:26:19 +0000
@@ -97,9 +97,12 @@
                         # classic snaps.
                         162.213.33.196, 162.213.33.200, 162.213.33.233,
                         91.189.92.19, 91.189.92.20, 91.189.92.38, 91.189.92.41,
-                        # public.apps.ubuntu.com, used by snapcraft to fetch
-                        # the core snap for builds of classic snaps.
+                        # public.apps.ubuntu.com/storage.snapcraftcontent.com,
+                        # used by snapcraft to fetch the core snap for
+                        # builds of classic snaps.
                         162.213.33.91, 162.213.33.92,
+                        162.213.33.43, 162.213.33.81, 162.213.33.128,
+                        162.213.33.220,
                         # kernel.ubuntu.com, used by some developers to
                         # fetch code.
                         91.189.94.216,