launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:unexporting-ocirecipe-build-attributes into launchpad:master.

Commit message:
Avoiding to export on the OCIRecipe API the build fields.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/381201
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:unexporting-ocirecipe-build-attributes into launchpad:master.

diff --git a/lib/lp/oci/interfaces/ocirecipe.py b/lib/lp/oci/interfaces/ocirecipe.py
index b80c25e..d5a7c92 100644
--- a/lib/lp/oci/interfaces/ocirecipe.py
+++ b/lib/lp/oci/interfaces/ocirecipe.py
@@ -20,7 +20,6 @@ __all__ = [
     'OCIRecipeNotOwner',
     ]
 
-from lazr.lifecycle.snapshot import doNotSnapshot
 from lazr.restful.declarations import (
     error_status,
     export_as_webservice_entry,
@@ -108,30 +107,30 @@ class IOCIRecipeView(Interface):
         description=_("The user who registered this recipe."),
         vocabulary='ValidPersonOrTeam', required=True, readonly=True))
 
-    builds = exported(doNotSnapshot(CollectionField(
+    builds = CollectionField(
         title=_("Completed builds of this OCI recipe."),
         description=_(
             "Completed builds of this OCI recipe, sorted in descending "
             "order of finishing."),
         # Really IOCIRecipeBuild, patched in _schema_circular_imports.
         value_type=Reference(schema=Interface),
-        required=True, readonly=True)))
+        required=True, readonly=True)
 
-    completed_builds = exported(doNotSnapshot(CollectionField(
+    completed_builds = CollectionField(
         title=_("Completed builds of this OCI recipe."),
         description=_(
             "Completed builds of this OCI recipe, sorted in descending "
             "order of finishing."),
         # Really IOCIRecipeBuild, patched in _schema_circular_imports.
-        value_type=Reference(schema=Interface), readonly=True)))
+        value_type=Reference(schema=Interface), readonly=True)
 
-    pending_builds = exported(doNotSnapshot(CollectionField(
+    pending_builds = CollectionField(
         title=_("Pending builds of this OCI recipe."),
         description=_(
             "Pending builds of this OCI recipe, sorted in descending "
             "order of creation."),
         # Really IOCIRecipeBuild, patched in _schema_circular_imports.
-        value_type=Reference(schema=Interface), readonly=True)))
+        value_type=Reference(schema=Interface), readonly=True)
 
     def requestBuild(requester, architecture):
         """Request that the OCI recipe is built.
diff --git a/lib/lp/oci/tests/test_ocirecipe.py b/lib/lp/oci/tests/test_ocirecipe.py
index aa8f686..379d0ce 100644
--- a/lib/lp/oci/tests/test_ocirecipe.py
+++ b/lib/lp/oci/tests/test_ocirecipe.py
@@ -397,8 +397,6 @@ class TestOCIRecipeWebservice(TestCaseWithFactory):
             date_created=Equals(recipe.date_created.isoformat()),
             date_last_modified=Equals(recipe.date_last_modified.isoformat()),
             registrant_link=Equals(self.getAbsoluteURL(recipe.registrant)),
-            pending_builds_collection_link=Equals(
-                recipe_abs_url + "/pending_builds"),
             webhooks_collection_link=Equals(recipe_abs_url + "/webhooks"),
             name=Equals(recipe.name),
             owner_link=Equals(self.getAbsoluteURL(recipe.owner)),