launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/lp-signing:fix-setup-packages into lp-signing:master.

Commit message:
Fix packages argument to setup

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/lp-signing/+git/lp-signing/+merge/381731

The packages argument didn't previously include the lp_signing package itself (as opposed to its subpackages), which is clearly incorrect.  This version is simpler and does a better job.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/lp-signing:fix-setup-packages into lp-signing:master.

diff --git a/setup.py b/setup.py
index e7eebeb..3e2b603 100755
--- a/setup.py
+++ b/setup.py
@@ -33,9 +33,7 @@ test_requires = [
 setup(
     name="lp-signing",
     version="0.1",
-    packages=[
-        f"lp_signing.{package}" for package in find_packages("lp_signing")
-        ],
+    packages=find_packages(),
     include_package_data=True,
     zip_safe=False,
     maintainer="Launchpad Developers",