← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~cjwatson/launchpad:fix-translation-sharing-job-derived into launchpad:master

 

The proposal to merge ~cjwatson/launchpad:fix-translation-sharing-job-derived into launchpad:master has been updated.

Description changed to:

This makes it a little more like other job classes, and in particular arranges that .job.id on its subclasses that implement IRunnableJob will refer to the ID of a Job table and not something else.

I ran into trouble with the slightly dodgy old approach while trying to fix BaseRunnableJob to work with transaction 3.0.0.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/382817
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:fix-translation-sharing-job-derived into launchpad:master.


References