launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lpbuildd/tests/test_snap.py b/lpbuildd/tests/test_snap.py
> index e747048..111698a 100644
> --- a/lpbuildd/tests/test_snap.py
> +++ b/lpbuildd/tests/test_snap.py
> @@ -434,13 +436,13 @@ class TestSnapBuildManagerIteration(TestCase):
>          proxy_listener = self.startLocalProxy(
>              self.getListenerURL(remote_proxy_listener))
>          out = yield self.assertCommandSuccess(
> -            [b"curl", remote_endpoint_url + b"a"],
> -            extra_env={b"http_proxy": self.getListenerURL(proxy_listener)})
> -        self.assertEqual("a" * 1024, out)
> +            [b"curl", remote_endpoint_url.encode("UTF-8") + b"a"],
> +            extra_env={"http_proxy": self.getListenerURL(proxy_listener)})
> +        self.assertEqual(b"a" * 1024, out)
>          out = yield self.assertCommandSuccess(
> -            [b"curl", remote_endpoint_url + b"b"],
> -            extra_env={b"http_proxy": self.getListenerURL(proxy_listener)})
> -        self.assertEqual("b" * 65536, out)
> +            [b"curl", remote_endpoint_url.encode("UTF-8") + b"b"],
> +            extra_env={"http_proxy": self.getListenerURL(proxy_listener)})
> +        self.assertEqual(b"b" * 65536, out)

Seems fair.  Done.

>  
>      # XXX cjwatson 2017-04-13: We should really test the HTTPS case as well,
>      # but it's hard to see how to test that in a way that's independent of


-- 
https://code.launchpad.net/~cjwatson/launchpad-buildd/+git/launchpad-buildd/+merge/383444
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad-buildd:py3-snap-proxy-tests into launchpad-buildd:master.