launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-webhook-payload-request into launchpad:master.

Commit message:
Convert WebhookPayloadRequest to BytesIO

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/384770

The body_instream argument to BaseRequest (and hence LaunchpadBrowserRequest etc.) is supposed to be a binary file object.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-webhook-payload-request into launchpad:master.

diff --git a/lib/lp/services/webhooks/payload.py b/lib/lp/services/webhooks/payload.py
index ccf899d..78b70b5 100644
--- a/lib/lp/services/webhooks/payload.py
+++ b/lib/lp/services/webhooks/payload.py
@@ -9,7 +9,7 @@ __all__ = [
     'WebhookPayloadRequest',
     ]
 
-import StringIO
+from io import BytesIO
 
 from lazr.restful.interfaces import IFieldMarshaller
 from zope.component import getMultiAdapter
@@ -30,7 +30,7 @@ class WebhookPayloadRequest(LaunchpadBrowserRequest):
     """An internal fake request used while composing webhook payloads."""
 
     def __init__(self):
-        super(WebhookPayloadRequest, self).__init__(StringIO.StringIO(), {})
+        super(WebhookPayloadRequest, self).__init__(BytesIO(), {})
 
 
 @implementer(IAbsoluteURL)