← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~twom/launchpad:sassy-css-fix-test-imports into launchpad:master

 

The proposal to merge ~twom/launchpad:sassy-css-fix-test-imports into launchpad:master has been updated.

Description changed to:

The JS tests import just the base CSS and test against it.
This was broken as the .css files no longer existed.

Create 'base.css' from the 'base.scss' and import it into the tests. Compile this separate (a fast operation) so that it's always present.

Also fix the 'combo.scss' imports so we're not importing base twice.

For more details, see:
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/384954
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:sassy-css-fix-test-imports into launchpad:master.


Follow ups