launchpad-reviewers team mailing list archive

[Tom Wardill <tom.wardill@xxxxxxxxxxxxx>]

Tom Wardill has proposed merging ~twom/launchpad:sassy-css-more-consistent-skins into launchpad:master.

Commit message:
Be more consistent with skin layouts

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/385050

Components can contain a -core.css and a -skin.css. Our build system expects both to exist, otherwise it won't compile the -core.css at all and the file will not be included in combo.css.

Pre-SASS all of the files were named explicitly, which is a bit strange for a skin/component system, so lets just make sure all the components are valid for the skin that we have ('sam').

Ensure that all the components have appropriate files, even if they are template (empty).
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:sassy-css-more-consistent-skins into launchpad:master.

diff --git a/lib/lp/app/javascript/confirmationoverlay/assets/skins/sam/confirmationoverlay-skin.css b/lib/lp/app/javascript/confirmationoverlay/assets/skins/sam/confirmationoverlay-skin.css
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/lib/lp/app/javascript/confirmationoverlay/assets/skins/sam/confirmationoverlay-skin.css
diff --git a/lib/lp/app/javascript/ordering/assets/skins/sam/ordering-skin.css b/lib/lp/app/javascript/ordering/assets/skins/sam/ordering-skin.css
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/lib/lp/app/javascript/ordering/assets/skins/sam/ordering-skin.css
diff --git a/lib/lp/app/javascript/ui/assets/skins/sam/banner.css b/lib/lp/app/javascript/ui/assets/skins/sam/banner-skin.css
similarity index 100%
rename from lib/lp/app/javascript/ui/assets/skins/sam/banner.css
rename to lib/lp/app/javascript/ui/assets/skins/sam/banner-skin.css